Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This closes #14, new function GetStyle has been added #16

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

lidp20
Copy link
Contributor

@lidp20 lidp20 commented Aug 31, 2023

PR Details

Description

New function GetStyle has been added.

Related Issue

#14

Motivation and Context

Support read style definition by given style index.

How Has This Been Tested

Add new test for this changes, and all unit test cases passed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 31, 2023
@xuri xuri linked an issue Aug 31, 2023 that may be closed by this pull request
@lidp20 lidp20 temporarily deployed to production August 31, 2023 16:34 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #16 (209ba33) into main (e9f9a02) will increase coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   98.32%   98.37%   +0.05%     
==========================================
  Files           1        1              
  Lines        2740     2831      +91     
==========================================
+ Hits         2694     2785      +91     
  Misses         35       35              
  Partials       11       11              
Flag Coverage Δ
unittests 98.37% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/main.go 98.37% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xuri xuri self-requested a review August 31, 2023 16:53
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 62fa747 into xuri:main Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to fn GetStyle
3 participants