Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New function DeleteFormControl has been added #13

Merged
merged 1 commit into from
Aug 30, 2023
Merged

New function DeleteFormControl has been added #13

merged 1 commit into from
Aug 30, 2023

Conversation

fsfsx
Copy link
Contributor

@fsfsx fsfsx commented Aug 29, 2023

PR Details

New function DeleteFormControl has been added

Related Issue

N/A

How Has This Been Tested

Add new unit test, and all test cases was passed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fsfsx fsfsx temporarily deployed to production August 29, 2023 14:41 — with GitHub Actions Inactive
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2023
xuri
xuri approved these changes Aug 30, 2023
View reviewed changes
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 42d2872 into xuri:main Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuri xuri xuri approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fsfsx @xuri