Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Dockerfile directory and install requirement first in Dockerfile #243

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

xiangsx
Copy link
Contributor

@xiangsx xiangsx commented Apr 28, 2023

  1. The Dockerfile should be placed in the project root directory for easier usage during the build process.
  2. The "copy requirements.txt" step should be moved to the beginning of the Docker build process to utilize cache in case of code changes during image build.
  3. The addition of the Chinese pip source has been commented out. Chinese users can uncomment it to get access to the source.

@xtekky xtekky merged commit 22bd61e into xtekky:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants