Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci error #684

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Fix ci error #684

merged 4 commits into from
Nov 14, 2023

Conversation

Diegovsky
Copy link
Collaborator

No description provided.

@Diegovsky
Copy link
Collaborator Author

Finally, it passes! @knokelmaat @xou816 could any of you please review the changes?

To summarize what I did: I updated ALL Cargo.lock dependencies with cargo update. I don't see a reason not to since we have a bunch of tests and semver guarantees it is fine to do so.

Also, updating in general is good for security. Some of the security problems raised by dependabot were solved just by doing so, I think.

@Diegovsky Diegovsky added the dependencies Pull requests that update a dependency file label Nov 2, 2023
This was referenced Nov 3, 2023
Open
Closed
@Diegovsky
Copy link
Collaborator Author

Thank you for the review @nmschulte. Would you happen to know why it can't be merged yet despite you approving it? (I'm not very experienced when it comes to PRs...)

@nmschulte
Copy link
Contributor

Would you happen to know why it can't be merged yet despite you approving it? (I'm not very experienced when it comes to PRs...)

Because I'm just a rando wizard with no power here, unfortunately. We need some greybeards ... https://www.youtube.com/watch?v=m_mPE9gcQJo

@Diegovsky Diegovsky mentioned this pull request Nov 3, 2023
Closed
@Diegovsky
Copy link
Collaborator Author

That's unfortunate

@knokelmaat knokelmaat merged commit aa1c578 into development Nov 14, 2023
5 checks passed
@k1gen
Copy link

k1gen commented Nov 19, 2023 •
edited
Loading

it still doesn't pass for me on Arch, rust 1.74.0. here's the testlog: https://0x0.st/HvRW.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knokelmaat knokelmaat knokelmaat approved these changes

@nmschulte nmschulte nmschulte approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Diegovsky @nmschulte @k1gen @knokelmaat