Implement track preloading for gapless playback #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
hey! thanks for the contribution, sorry about the long wait! thanks for the review Diegovsky :) lets see how the CI goes |
xou816
reviewed
Feb 12, 2023
src/player/player.rs
Outdated
| @@ -137,6 +140,11 @@ impl SpotifyPlayer { | |||
| .load(track, true, 0); | |||
| Ok(()) | |||
| } | |||
| Command::PlayerPreload(track) => { | |||
| let player = player.as_mut().ok_or(SpotifyError::PlayerNotReady)?; | |||
There was a problem hiding this comment.
Suggested change
| let player = player.as_mut().ok_or(SpotifyError::PlayerNotReady)?; | |
| let player = self.player.as_mut().ok_or(SpotifyError::PlayerNotReady)?; |
There was a problem hiding this comment.
Yeah that makes sense. I skimmed it over because the code looked correct lol. Anyhow, I will look more carefully in the future :)
There was a problem hiding this comment.
oh no no it was okay! its just that I had pushed to develop in the meantime and things needed adjusting, but it was all good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds librespot track preloading and a new setting for gapless playback.
Fixes #193 and #502.