Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon: new spotlight metaphor, add symbolic, add source file #483

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

bertob
Copy link
Contributor

@bertob bertob commented Mar 13, 2022

This adds a new app icon, as discussed in #481. I just replaced the assets in this MR, so the build system needs adjusting in a followup.

image

@xou816
Copy link
Owner

xou816 commented Mar 13, 2022

Hi! Again, this looks so much better than the existing icon, thanks a lot! I like how the symbolic icon gives another take on that metaphor too :)

As for the build system adaptation: do you mean we should rasterize the svg as part of the build process? I'm guessing standard tools exist for that?

@bertob
Copy link
Contributor Author

bertob commented Mar 13, 2022

No, you don't need to rasterize it, standard practice is to just use the SVG.

@xou816
Copy link
Owner

xou816 commented Mar 13, 2022

Oh okay so it's just a matter of putting files in the right folders then I suppose :)

@bertob
Copy link
Contributor Author

bertob commented Mar 15, 2022

I think the file paths in the data folder don't really matter, it's mostly a matter of adjusting the gresource/build system stuff. Not really my area of expertise though :)

@Toorero
Copy link
Contributor

Toorero commented Mar 16, 2022

Just execute this in the git root, and it works flawlessly no need to adjust the build system.

mkdir -p data/hicolor/scalable/apps
mv data/dev.alextren.Spot.svg data/hicolor/scalable/apps

The other option would be (as you suggested) to adjust the build system. For inspiration, you could use Newsflash, but I think that's unnecessary. Just move it.

@xou816
Copy link
Owner

xou816 commented Mar 17, 2022

Hi! Yes, indeed, thanks @Toorero !

The build system already installs the hicolor directory: https://github.com/xou816/spot/blob/development/data/meson.build#L6

So indeed moving data/dev.alextren.Spot.svg to data/hicolor/scalable/apps should be enough

And the symbolic icon should be in data/hicolor/symbolic/apps I think

@xou816 xou816 merged commit b12d865 into xou816:development Mar 27, 2022
@xou816
Copy link
Owner

xou816 commented Mar 27, 2022

I took the liberty to move the files as mentioned, and merged :) thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants