Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically try other ports in case of timeouts #363

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

sei0o
Copy link
Contributor

@sei0o sei0o commented Nov 8, 2021

Fixes #343. SessionError::IoError corresponds to a timeout. If ap-port value in gsettings is set, it won't connect to any other port.

@sei0o
Copy link
Contributor Author

sei0o commented Nov 8, 2021

rustfmt says error[E0670]: async fn is not permitted in Rust 2015 ...Seems strange, will look into it later.

@sei0o sei0o marked this pull request as draft November 8, 2021 01:34
@xou816
Copy link
Owner

xou816 commented Nov 8, 2021

Hi there, thanks for the contribution :) maybe your local rust toolchain is not up to date?

src/player/player.rs Outdated Show resolved Hide resolved
src/player/player.rs Outdated Show resolved Hide resolved
src/player/player.rs Outdated Show resolved Hide resolved
@sei0o sei0o marked this pull request as ready for review November 9, 2021 01:45
@xou816
Copy link
Owner

xou816 commented Nov 9, 2021

Perfect, LGTM, merging! thanks for your work!

@xou816 xou816 merged commit e83f532 into xou816:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try multiple AP ports in case of timeouts
2 participants