Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor label changes for the new login screen #625

Closed
bragefuglseth opened this issue Mar 1, 2023 · 1 comment · Fixed by #642
Closed

Minor label changes for the new login screen #625

bragefuglseth opened this issue Mar 1, 2023 · 1 comment · Fixed by #642
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bragefuglseth
Copy link

bragefuglseth commented Mar 1, 2023

Note: This is a low-priority issue, but excellent for newcomers!

The new login screen is coming together nicely! 🎉

new-login

I have a few things on the label/string side that I think could be changed:

  • The "Login with your Spotify Account" label beneath the title could be justified to the center, to match the rest of the text on the page. I think this just requires adding justify: center; to the label in the login blueprint file, but my building skills aren't quite there yet, so I'm not able to test it.

  • "Login" should be "Log in". I had to search that up. "Login" is a noun/adjective ("the login window"), "log in" is a verb ("I tried to log in"). Also, "to use Spot" could be changed to "to use the app", so we avoid the slightly awkward repetition of the app name from the "Welcome to Spot" label. Or we could just drop the "to use x" part altogether, as it's kinda implied from the fact that you're trying to log in. This is my suggestion for the label:

    Log in with your Spotify account. A Spotify Premium subscription is required to use the app.

  • I don’t have an easy-to-remember Spotify username, as it was automatically generated when we created our family subscription, but I’m able to log in with my email in the username field. We should specify that that’s possible as well. We can do this by changing the "Username" label to "Username or Email". Another web search reveals that both "E-mail" and "Email" are acceptable writing methods, but Email is the most common one. The most important thing is that it's Header Capitalized in accordance with the HIG 😁

I'm going to stop annoying you with my design nitpicking for now, cheers 😅

@xou816
Copy link
Owner

xou816 commented Mar 2, 2023

I'm going to stop annoying you with my design nitpicking for now, cheers sweat_smile

I don't mind it no worries :)

@xou816 xou816 added the bug Something isn't working label Mar 2, 2023
@xou816 xou816 added the good first issue Good for newcomers label Mar 19, 2023
hegdenischay added a commit to hegdenischay/spot that referenced this issue Mar 31, 2023
hegdenischay added a commit to hegdenischay/spot that referenced this issue Mar 31, 2023
@xou816 xou816 linked a pull request Apr 4, 2023 that will close this issue
xou816 added a commit that referenced this issue Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants