Toml.TryToModel not calling ConvertTo option

[donaldblodgett]

I am attempting to use Tomlyn to read/write a model that contains properties that are non-primitive. Given the following code I would expect that the resulting model would contain the Uri as parsed from the sample text as the TomlModelOptions.ConvertTo is defined. Instead the test fails with the diagnostics containing the following error:

The property value of type System.String couldn't be converted to System.Uri for the property Tests+Config/service_uri

    [Test]
    public void TestUri()
    {
        var expected = new Uri("https://example.com");
        var text = @$"service_uri = ""{expected}""";
        var options = new TomlModelOptions
        {
            ConvertTo = (value, type) => new Uri((string)value)
        };
        var success = Toml.TryToModel<Config>(text, out var result, out var diagnostics, null, options);
        
        Assert.True(success);
        Assert.AreEqual(expected, result?.ServiceUri);
    }

    public class Config
    {
        public Uri ServiceUri { get; set; }
    }

Through debugging this issue it seems that if I temporarily change the value of the variable value at the following line to null

Tomlyn/src/Tomlyn/Model/Accessors/DynamicModelReadContext.cs

Line 92 in 9d99bb3

if (value is IConvertible)

and then revert it back to the original value at the following line

Tomlyn/src/Tomlyn/Model/Accessors/DynamicModelReadContext.cs

Line 164 in 9d99bb3

if (ConvertTo is not null)

then the ConvertTo option is successfully called and the test passes.

[xoofx]

This is fixed by commit 9b0e19e

Tomlyn/src/Tomlyn.Tests/ModelTests/ReflectionModelTests.cs

Lines 31 to 48 in 9b0e19e

	[Test]
	public void TestUri()
	{
	var expected = new Uri("https://example.com");
	var text = @$"service_uri = ""{expected}""";
	var options = new TomlModelOptions
	{
	ConvertToModel = (value, type) => type == typeof(Uri) ? new Uri((string)value) : null,
	ConvertToToml = (value) => value is Uri uri ? uri.ToString() : null
	};
	var success = Toml.TryToModel<TestConfigWithUri>(text, out var result, out var diagnostics, null, options);
	Assert.True(success);
	Assert.AreEqual(expected, result?.ServiceUri);
	var tomlText = Toml.FromModel(result!, options);
	Assert.AreEqual($"service_uri = \"{expected}\"", tomlText.Trim());
	}

There are now 2 properties:

• TomlModelOptions.ConvertToModel (previously ConvertTo).
• TomlModelOptions.ConvertToToml to allow to convert back a custom type to a TOML representation.

Should be available in 0.14.0+