Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webconfig image #5079

Closed
wants to merge 11 commits into from
Closed

Remove webconfig image #5079

wants to merge 11 commits into from

Conversation

anki-code
Copy link
Member

@anki-code anki-code commented Mar 2, 2023

subj

follow up #5077

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Warning! No news item is found for this PR.
If this is an user facing change/feature/fix, please add a news item by copying the format from news/TEMPLATE.rst.

@anki-code anki-code changed the title Replace icon image from 300kb to 30kb Replace icon image from 340kb to 23kb Mar 2, 2023
@anki-code anki-code changed the title Replace icon image from 340kb to 23kb Reduce icon image size from 340kb to 23kb Mar 2, 2023
@anki-code
Copy link
Member Author

anki-code commented Mar 2, 2023

@jnoortheen RTR
no news

@anki-code anki-code changed the title Reduce icon image size from 340kb to 23kb Reduce webconfig icon image size from 340kb to 23kb Mar 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #5079 (f3313b4) into main (71ac21f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5079      +/-   ##
==========================================
+ Coverage   66.72%   66.76%   +0.03%     
==========================================
  Files         129      129              
  Lines       23862    23862              
  Branches     4503     4503              
==========================================
+ Hits        15923    15931       +8     
+ Misses       6710     6701       -9     
- Partials     1229     1230       +1     
Flag Coverage Δ
macOS-latest 64.08% <ø> (+0.03%) ⬆️
ubuntu-latest 64.31% <ø> (+<0.01%) ⬆️
windows-latest 62.71% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xonsh/jobs.py 51.36% <0.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anki-code anki-code changed the title Reduce webconfig icon image size from 340kb to 23kb Reduce webconfig icon image size Mar 2, 2023
@anki-code anki-code changed the title Reduce webconfig icon image size Remove webconfig image Mar 2, 2023
@anki-code
Copy link
Member Author

I decide to remove the image because it's small not useful image.

@anki-code
Copy link
Member Author

anki-code commented Mar 3, 2023

@jnoortheen I'm for removing the image from the package because it isn't useful and increase the size of the package. I'm for lightweight webconfig.
Also this icon was broken during long time and no one reported about it.

@anki-code
Copy link
Member Author

#5081

@anki-code anki-code closed this Mar 4, 2023
@anki-code anki-code deleted the anki-code-patch-7 branch December 26, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants