setBlob should run after setAlgorithm #2217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically you are correct, but if you check the code it only matters for KawPow which uses EthStratumClient where it's already in the correct order. So there's no bug for other algorithms here. |
yes, but maybe it could be more robustness if change the call order |
SChernykh
approved these changes
Mar 29, 2021
|
Merged into dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, is there a bug? because the function xmrig::Job::setBlob call nonceOffset and nonceSize which use the algorithm family, so if algorithm family change after setBlob there may be a bug