Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve print_os_info on systems with non-contiguous memory maps #11

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

eblanton
Copy link
Contributor

@eblanton eblanton commented Mar 5, 2017

The print_os_info() function assumes contiguous memory maps (e.g., _etext == _sdata), which is often untrue on embedded systems. This patch removes that assumption to some degree.

@hzhou81
Copy link
Contributor

hzhou81 commented Mar 7, 2017

I agree with this improvement!

@hzhou81
Copy link
Contributor

hzhou81 commented Mar 7, 2017

The most important thing is we must find the maintainer of the project to deal with the pull request.

@brylow
Copy link
Contributor

brylow commented Mar 7, 2017 via email

@hzhou81
Copy link
Contributor

hzhou81 commented Mar 7, 2017

Quoting brylow:
Don't be shame, I'm your and your students's fan. You can invite your students to be maintainers.
I'm willing to contribute code to this project. Xinu must keep going!

@eblanton
Copy link
Contributor Author

eblanton commented Mar 7, 2017

Let me know if you have a more preferred integration path, Dennis. As you may recall, a decade or so ago I ported Xinu to the STM32 family of microprocessors, and was waiting on some platform generalization to upstream it. Well, the world has come around to me working on it again, and I'm about ready to push it.

@brylow brylow merged commit 3370714 into xinu-os:master Nov 10, 2017
@eblanton eblanton deleted the print_os_info branch November 10, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants