Making vue-color work with v-model. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the event to 'input' will make the component work with v-model. + Adding yarn.lock Docs: https://vuejs.org/v2/guide/components.html#Form-Input-Components-using-Custom-Events
|
This change broke my application that was written with @change-color. The change is not a bad idea, but it is a breaking change, so according to SemVer, it should have been released along with an update to the major version number, not just a patch number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the event to 'input' will make the component work with v-model.
Docs:
https://vuejs.org/v2/guide/components.html#Form-Input-Components-using-Custom-Events
This way, when using the component, it's possible to only use
v-modelwithout@change-color="onChange".