Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is suppose to fix the issue #49 and #25
For #25 there is no right solution at the moment. Tinycolor will set the values to black if hsl's "L"(for light, same for V in hsv) reach zero. The solution would be use some kind of cache or avoid to reach zero when moving the circle, that's what I did.
#49 was solved by checking if data exists before using.
@xiaokaike could you download this branch and test it out before accepting it ? I created the dist on Windows and I can't trust it, but should it be fine.