Accept only hex when creating the color picker #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was needing this to work in my project and I think it's nice to have this option. If you only define the hex value in the colors prop it won't work, since the colors mixin need the other values which are calculated on change. I got your function that did the recalculation(colorChange method) and move it to a function and reuse it in the created function. I did a simple test and it worked fine. Feel free to accept or not, I was going to open a issue but since it's simple, one PR is fine IMO. Thank you for the vue-color. Feel free to contact me if necessary.