Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that
Photoshop.vue
uses$dispatch
method, which has been deprecated since Vue.js 2.0. The use of$dispatch
is resulting in the below error in the console when you click the "OK" and "Cancel" buttons. Although this is not a critical bug or anything, I just thought people would be confused to see such error, so I've replaced them with the simple$emit
API, which properly triggers theconsole.log('ok')
andconsole.log('cancel')
insideApp.vue
.BEFORE
AFTER
ref: vuejs/vue 2.0 Changes