Changes to Saturation/Hue.vue to isolate X/Y Events and Fix #113 #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issues in #113.
What I have done for both Saturation and Hue X/Y elements is to make them separate from the global colors variable and to use a local data variable.
With this change, the issue of the Hue slider shunting to the left when the pointer goes to the bottom AND the effect that I have seen. Is when the pointer goes near to the bottom, it sometimes itself shunts to the left or right.
Now this is not the case.
Finally, I've only had a limited amount of time to work on this. I'm sure the code could be refactored better. Maybe for 3.0?
Also please test and ensure this does not degrade the color data in anyway!