Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations for accessibility improvements #160

Closed
NateWr opened this issue Sep 26, 2018 · 3 comments
Closed

Recommendations for accessibility improvements #160

NateWr opened this issue Sep 26, 2018 · 3 comments

Comments

@NateWr
Copy link

NateWr commented Sep 26, 2018

I saw that you added aria-label and role attributes to some of the buttons. In addition, it would be nice if the relationship of the input fields to other helpful text could be defined by passing aria-labelledby and aria-describedby props to the component, which would then be attached to the input fields.

Also, a non-technical accessibility requirement for us would be the ability to translate the existing labels in the component. Would you consider a strings prop for overriding any English-language labels you've applied to buttons in the component?

@linx4200
Copy link
Collaborator

I see your point.

  • Add improve accessibility by adding aria-labelledby and aria-describedby.
  • Allow to customize labels in favor of i18n.

I think I can manage these improvements within this week and release a new version. Thanks.

@linx4200
Copy link
Collaborator

Sorry for the delay. We have released v2.7.0. You can find more details here.

@NateWr
Copy link
Author

NateWr commented Oct 18, 2018

Thanks, we've updated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants