Skip to content

Commit

Permalink
[java] Removing mentions to firefox-bin in docs and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
diemol committed Dec 22, 2023
1 parent 6c3110a commit d3bccee
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions java/src/org/openqa/selenium/grid/node/config/NodeFlags.java
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public class NodeFlags implements HasRoles {
+ "webdriver-path=\"/usr/local/bin/geckodriver\" "
+ "stereotype='{\"browserName\": \"firefox\", \"browserVersion\": \"86\", "
+ "\"moz:firefoxOptions\": "
+ "{\"binary\":\"/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin\"}}'",
+ "{\"binary\":\"/Applications/Firefox Nightly.app/Contents/MacOS/firefox\"}}'",
arity = 4,
variableArity = true,
splitter = NonSplittingSplitter.class)
Expand All @@ -168,7 +168,7 @@ public class NodeFlags implements HasRoles {
+ "max-sessions = 2\n"
+ "stereotype = \"{\\\"browserName\\\": \\\"firefox\\\", \\\"browserVersion\\\":"
+ " \\\"86\\\", \\\"moz:firefoxOptions\\\": {\\\"binary\\\":\\\"/Applications/Firefox"
+ " Nightly.app/Contents/MacOS/firefox-bin\\\"}}\"")
+ " Nightly.app/Contents/MacOS/firefox\\\"}}\"")
public List<String> driverConfiguration;

@Parameter(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ void canBeConfiguredToUseHelperClassesToCreateSessionFactories() {
void driversCanBeConfigured() {
String chromeLocation =
"/Applications/Google Chrome Beta.app/Contents/MacOS/Google Chrome Beta";
String firefoxLocation = "/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin";
String firefoxLocation = "/Applications/Firefox Nightly.app/Contents/MacOS/firefox";
ChromeOptions chromeOptions = new ChromeOptions();
chromeOptions.setBinary(chromeLocation);
FirefoxOptions firefoxOptions = new FirefoxOptions();
Expand Down Expand Up @@ -436,7 +436,7 @@ void driversCanBeConfigured() {
@Test
void driversCanBeConfiguredWithASpecificWebDriverBinary() {
String chLocation = "/Applications/Google Chrome Beta.app/Contents/MacOS/Google Chrome Beta";
String ffLocation = "/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin";
String ffLocation = "/Applications/Firefox Nightly.app/Contents/MacOS/firefox";
String chromeDriverLocation = "/path/to/chromedriver_beta/chromedriver";
String geckoDriverLocation = "/path/to/geckodriver_nightly/geckodriver";
ChromeOptions chromeOptions = new ChromeOptions();
Expand Down

0 comments on commit d3bccee

Please sign in to comment.