Skip to content

Commit

Permalink
[dotnet] Fix building errors of the solution in VS via isolating outp…
Browse files Browse the repository at this point in the history
…ut path per project (SeleniumHQ#12063)

* Isolate bin output per project

* Ignore bin folder only for dotnet

---------

Co-authored-by: Diego Molina <[email protected]>
  • Loading branch information
nvborisenko and diemol committed May 19, 2023
1 parent b985016 commit 7cd20cf
Show file tree
Hide file tree
Showing 11 changed files with 8 additions and 72 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ selenium.egg-info/
third_party/java/jetty/jetty-repacked.jar
*.user
*.cache
dotnet/**/bin/
obj/
*.opensdf
*.suo
Expand Down
4 changes: 0 additions & 4 deletions dotnet/src/support/WebDriver.Support.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
<BuildSystem>visual-studio</BuildSystem>
</PropertyGroup>

<PropertyGroup>
<OutputPath>..\..\..\build\cli\$(Configuration)\</OutputPath>
</PropertyGroup>

<PropertyGroup>
<AssemblyTitle>Selenium WebDriver Support</AssemblyTitle>
<Description>Selenium WebDriver .NET Bindings support classes</Description>
Expand Down
4 changes: 0 additions & 4 deletions dotnet/src/webdriver/WebDriver.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
<RootNamespace>OpenQA.Selenium</RootNamespace>
</PropertyGroup>

<PropertyGroup>
<OutputPath>..\..\..\build\cli\$(Configuration)\</OutputPath>
</PropertyGroup>

<PropertyGroup>
<AssemblyTitle>WebDriver</AssemblyTitle>
<Description>Selenium WebDriver API .NET Bindings</Description>
Expand Down
9 changes: 1 addition & 8 deletions dotnet/test/chrome/WebDriver.Chrome.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
<AssemblyName>WebDriver.Chrome.Tests</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand All @@ -31,6 +23,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
</ItemGroup>
Expand Down
8 changes: 0 additions & 8 deletions dotnet/test/common/WebDriver.Common.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
<RootNamespace>OpenQA.Selenium</RootNamespace>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand Down
9 changes: 1 addition & 8 deletions dotnet/test/edge/WebDriver.Edge.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
<AssemblyName>WebDriver.Edge.Tests</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand All @@ -33,6 +25,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
</ItemGroup>
Expand Down
9 changes: 1 addition & 8 deletions dotnet/test/firefox/WebDriver.Firefox.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
<AssemblyName>WebDriver.Firefox.Tests</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand Down Expand Up @@ -44,6 +36,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
</ItemGroup>
Expand Down
9 changes: 1 addition & 8 deletions dotnet/test/ie/WebDriver.IE.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
<RootNamespace>OpenQA.Selenium.IE</RootNamespace>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand All @@ -32,6 +24,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
</ItemGroup>
Expand Down
9 changes: 1 addition & 8 deletions dotnet/test/remote/WebDriver.Remote.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
<AssemblyName>WebDriver.Remote.Tests</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand All @@ -29,6 +21,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
</ItemGroup>
Expand Down
9 changes: 1 addition & 8 deletions dotnet/test/safari/WebDriver.Safari.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
<AssemblyName>WebDriver.Safari.Tests</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand All @@ -30,6 +22,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
</ItemGroup>
Expand Down
9 changes: 1 addition & 8 deletions dotnet/test/support/WebDriver.Support.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
<AssemblyName>WebDriver.Support.Tests</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<OutputPath>..\..\..\build\cli\Debug\</OutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<OutputPath>..\..\..\build\cli\Release\</OutputPath>
</PropertyGroup>

<ItemGroup>
<Compile Remove="obj\**" />
<EmbeddedResource Remove="obj\**" />
Expand All @@ -29,6 +21,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="Moq" Version="4.13.0" />
<PackageReference Include="NUnit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
Expand Down

0 comments on commit 7cd20cf

Please sign in to comment.