Skip to content

Commit

Permalink
[dotnet] Improve file logging code smell based on feedback from 13249
Browse files Browse the repository at this point in the history
  • Loading branch information
nvborisenko committed Dec 8, 2023
1 parent 8063da2 commit 46946e9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace OpenQA.Selenium.Internal.Logging
{
public class FileLogHandlerTest
{
[Test]
[TestCase(null)]
[TestCase("")]
public void ShouldNotAcceptIncorrectPath(string path)
Expand All @@ -30,10 +29,6 @@ public void ShouldHandleLogEvent()

Assert.That(File.ReadAllText(tempFile), Does.Contain("test message"));
}
catch (Exception)
{
throw;
}
finally
{
File.Delete(tempFile);
Expand Down
1 change: 0 additions & 1 deletion dotnet/test/common/Internal/Logging/LogTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public void LoggerShouldEmitEvent()
Assert.That(logEvent.Timestamp, Is.EqualTo(DateTimeOffset.Now).Within(100).Milliseconds);
}

[Test]
[TestCase(LogEventLevel.Trace)]
[TestCase(LogEventLevel.Debug)]
[TestCase(LogEventLevel.Info)]
Expand Down

0 comments on commit 46946e9

Please sign in to comment.