Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not package the tests in the bdist/wheel #104

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

musicinmybrain
Copy link
Contributor

It seems like this was the intent from the beginning, but the pattern tests* in the excludes for find_package does not match anything. This PR adjusts that pattern to pyxdf.test* so that the tests are not unnecessarily included with wheel/binary distributions.

The other two entries, contrib and docs, could also be removed, since they don’t match anything either.

@cbrnr
Copy link
Contributor

cbrnr commented Apr 18, 2024

I'm not sure that we want to exclude tests from the distribution package. I know that opinions differ, but I tend to think that having tests with an installed package can be useful.

Having said that, some tests provided with pyxdf require testing data from a different repository, so they would not work out of the box. Therefore, I'm fine with removing the tests (for now). Can you also remove the other two unused entries?

Eventually, we should switch to pyproject.toml BTW.

@musicinmybrain
Copy link
Contributor Author

Thanks for the feedback. That’s a reasonable (and reasonably nuanced) perspective.

I’ve removed the unused excludes in a follow-up commit.

@cbrnr cbrnr merged commit 68a0081 into xdf-modules:main Apr 18, 2024
@cbrnr
Copy link
Contributor

cbrnr commented Apr 18, 2024

Thanks @musicinmybrain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants