Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

003-muted-words #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

003-muted-words #11

wants to merge 2 commits into from

Conversation

cwinhall2
Copy link

My initial proposal for muted words endpoint.

This is my first ever time using github beyond cloning. I have probably missed some technical requirements or not understood how to do this completely correctly. Happy to take on advice and make changes to the proposal where required.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. We ask that you agree to the Twitter Developer Agreement and Policy before we can accept your proposal. You can agree by posting a comment with the following text:


I have read and agree to the Twitter Developer Agreement and Policy


You can retrigger this bot by commenting recheck in this Pull Request

@cwinhall2
Copy link
Author

I have now signed the CLA

@igorbrigadir
Copy link
Contributor

igorbrigadir commented Apr 18, 2022

Great! This would be super useful.

I'm not Twitter but for what it's worth, the API and responses should be in v2 format (right now the examples you have are v1.1)

As a user, I would also expect the muted words management to closely resemble Streaming Rules, so, having the keyword / rule, as well as the label, and the same style of pagination etc and the same data and meta parts of the response https://developer.twitter.com/en/docs/twitter-api/tweets/filtered-stream/api-reference/post-tweets-search-stream-rules and https://developer.twitter.com/en/docs/twitter-api/tweets/filtered-stream/api-reference/get-tweets-search-stream-rules for reference

Also just a personal idea, but it would be awesome to be able to add mutes with the same query language and operators as either the v2 search API or the web search API. That would make things super useful and interesting.

Hope this gets picked up!

@iamdaniele
Copy link
Contributor

Hi @cwinhall2, I will be the review manager for this proposal. The team will evaluate the proposal and I will get back to you within two weeks.

@cwinhall2
Copy link
Author

Hi @cwinhall2, I will be the review manager for this proposal. The team will evaluate the proposal and I will get back to you within two weeks.

Hey @iamdaniele, any update on this or is Elon getting in the way? hehe :-P

@iamdaniele
Copy link
Contributor

@cwinhall2 The review team is set to discuss the proposal this week, and we should have an update for you by end of day (Pacific Time) on 2022-05-06.

@iamdaniele
Copy link
Contributor

iamdaniele commented May 5, 2022

Hi @cwinhall2 and thank you for taking the time to author and submit this proposal. The review team is moving toward accepting your proposal upon revision. This means there are a few changes we’d like you to make before we can accept the proposal:

  • The proposal as authored references v1.1. Please note that Open Evolution can only accept proposal for the Twitter API v2 and above. Please change the proposal so that the requests can refer to v2 or above. This includes doing the following:
    • Ensure the endpoint URL and method are consistent with the v2 design; for example, they shouldn't have the .json suffix
    • Ensure the response payload matches the format of the v2 data dictionaries. This for example includes treating IDs as strings instead of relying on the id/id_str field combination.

The proposal will remain in an Open state until your changes are authored. Once you're done, simply push another commit to this pull request and feel free to @ mention me here. At that point, we'll kick off another review process and we will get back to you by 15 working days from that date. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants