[EDL][Players] Cleanup FIXMEs #25346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
added
Type: Improvement
howie-f
approved these changes
Jun 19, 2024
enen92
force-pushed
the
cleanup_fixme_edl
branch
from
35e14ab
to
9a122f5
Compare
fuzzard
approved these changes
Jun 22, 2024
ksooo
reviewed
Jun 22, 2024
xbmc/cores/VideoPlayer/Edl.cpp
Outdated
| @@ -882,37 +884,37 @@ EDL::Action CEdl::GetLastEditActionType() const | |||
| return m_lastEditActionType; | |||
| } | |||
|
|
|||
| bool CEdl::GetNextSceneMarker(bool bPlus, const int iClock, int *iSceneMarker) | |||
| bool CEdl::GetNextSceneMarker(Direction direction, int clock, int* sceneMarker) | |||
There was a problem hiding this comment.
Would it be possible to replace the int pointer with a reference?
There was a problem hiding this comment.
I was not really interested in doing more in this PR but done in b872735
enen92
force-pushed
the
cleanup_fixme_edl
branch
from
9a122f5
to
0a4fb52
Compare
enen92
force-pushed
the
cleanup_fixme_edl
branch
from
0a4fb52
to
b872735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides a few assorted improvements to the EDL interface (mostly leftovers):
I don't want it to grow bigger than it's already so please consider other stuff out of the scope.