Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests for CGUIControlFactory #25310

Merged
merged 9 commits into from
Jun 23, 2024

Conversation

notspiff
Copy link
Contributor

@notspiff notspiff commented Jun 7, 2024

Description

This adds some tests for CGUIControlFactory. They are not, nor meant to be, exhaustive tests for the logic, but only to help aid refactoring the XML parsing bits.

They are also not complete but this is all the monkey work I could stomach in one evening.

Motivation and context

2 > 1

How has this been tested?

Uhm, it is tests, dummy. It's tested by running the tests.

What is the effect on users?

None

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@notspiff notspiff added Type: Improvement non-breaking change which improves existing functionality Component: GUI engine v22 Piers labels Jun 7, 2024
@notspiff notspiff added this to the "P" 22.0 Alpha 1 milestone Jun 7, 2024
@fuzzard
Copy link
Contributor

fuzzard commented Jun 8, 2024

Jenkins build this please

Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thus more tests was superior to less tests. Good work.

@notspiff notspiff force-pushed the add_guicontrol_factory_tests branch 2 times, most recently from 6644e18 to edcc2b2 Compare June 10, 2024 14:43
Copy link
Contributor

@fuzzard fuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im happy to ignore the jenkins formatting for this. In a lot of the cases in the test file it makes things a little less readable

@notspiff notspiff force-pushed the add_guicontrol_factory_tests branch 3 times, most recently from 2eb4281 to 4bfe47a Compare June 11, 2024 18:30
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Jun 15, 2024
@notspiff notspiff force-pushed the add_guicontrol_factory_tests branch from 4bfe47a to e9bdd97 Compare June 23, 2024 19:25
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Jun 23, 2024
@notspiff notspiff merged commit 8d1bef6 into xbmc:master Jun 23, 2024
2 checks passed
@notspiff notspiff deleted the add_guicontrol_factory_tests branch June 23, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Improvement non-breaking change which improves existing functionality v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants