[addons] introduce advanced setting to allow showing all dependencies in dialog

[howie-f]

Description

• allows to disable filtering of low-level dependencies (e.g. ADDON_SCRIPT_MODULE) in the dependency select dialog
  by setting <showalldependencies>yes</showalldependencies> in advancedsettings.xml

How Has This Been Tested?

examined the depends dialog for the YouTube add-on in the official repository

Types of change

• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)

Checklist:

• My code follows the Code Guidelines of this project
• I have read the Contributing document

like discussed on slack with @basrieter

[ksooo]

v19? Don't think we accept new features at this stage, especially as this PR intorduces new GUI strings, which need to be translated into >70 languages until v19 release.

[enen92]

I was sort of inclined to say the same. This isn't really a new feature but restores Leia behaviour instead for python addon developers. Nevertheless, @ksooo is right. So probably something like below would work?

• Use an advanced setting instead of an expert level setting for v19
• Prepare a PR to drop the advanced setting and use an expert setting for v20
• It's not the time to do the keyboard cleanup commit. Make a second PR for v20 with that instead

[howie-f]

all perfectly true. then we‘ll go the advancedsettings.xml way for now if no one objects. dumb it wasn‘t discovered earlier. would that be ok @ksooo ?

[basrieter]

all perfectly true. then we‘ll go the advancedsettings.xml way for now if no one objects. dumb it wasn‘t discovered earlier. would that be ok @ksooo ?

It's a shame I did not run into it earlier. But understandable from a release point of view. Advancedsettings.xml seems like a good place for now. Perhaps we can not delay the GUISettings until v20, but v19.1?

[ksooo]

Perhaps we can not delay the GUISettings until v20, but v19.1?

So far we had the policy that minors are for bug fixes only. And I'm not sure there will be any translation cycles for minors.

advancedsettings approch is fine for me. Not sure this will need a gui setting at all. For me this is a very special, beyond expert level functionality, thus I would even stick with advancedsettings as the final solution.

[howie-f]

I would even stick with advancedsettings as the final solution.

agreed, the gui change was the first thing on my mind. as you can see the first isn't the best in that case.
guess addon-devs who need to see all dependencies set it up once and that's that.

[garbear]

No changes requested, but suggestions offered for future PRs:

• Could be const bool showAllDependencies = ...

• Could split long boolean conditions for readability, e.g.:

bool showDependency = false;

if (showAllDependencies)
  showDependency = true;
else if (addonInstalled && addonInstalled->MainType() != ADDON_SCRIPT_MODULE)
  showDependency = true;
else if (addonAvailable && addonAvailable->MainType() != ADDON_SCRIPT_MODULE)
  showDependency = true;
else if (!addonAvailable && !addonInstalled)
  showDependency = true;

if (showDependency)
{
  ...
}