Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PVR] Fix EPG last scan time handling. #18970

Merged
merged 1 commit into from
Dec 22, 2020
Merged

[PVR] Fix EPG last scan time handling. #18970

merged 1 commit into from
Dec 22, 2020

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Dec 22, 2020

Three fixes:

  1. Last epg scan time was not always stored in the epg db
  2. Last epg scan time was never loaded from the db - 1. and 2. leading to too many EPG data fetches from the clients.
  3. Last epg scan time row was not removed from the db when the associated EPG was deleted from the db - leaving the db with orphaned data.

Runtime.tested on macOS and Android, latest Kodi master.

@phunkyfish are you in the mood for a code review?

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v19 Matrix labels Dec 22, 2020
@ksooo ksooo added this to the Matrix 19.0-RC1 milestone Dec 22, 2020
phunkyfish
phunkyfish approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@ksooo ksooo merged commit 95ec740 into xbmc:master Dec 22, 2020
@ksooo ksooo deleted the pvr-fix-lastepgscan branch December 22, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phunkyfish phunkyfish phunkyfish approved these changes

Assignees
No one assigned
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksooo @phunkyfish