Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pvr] - json GetTimers to return broadcast id as it is now the unique epg identifier #18968

Merged
merged 1 commit into from
Dec 23, 2020
Merged

[pvr] - json GetTimers to return broadcast id as it is now the unique epg identifier #18968

merged 1 commit into from
Dec 23, 2020

Conversation

phunkyfish
Copy link
Contributor

@phunkyfish phunkyfish commented Dec 22, 2020 •
edited
Loading

Description

Should fix: #18960

Motivation and Context

Not possible to retrieve the epg data for a time without this value being returned.

How Has This Been Tested?

Tested on Mac OSX.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish added this to the Matrix 19.0-RC1 milestone Dec 22, 2020
ksooo
ksooo approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx.

@phunkyfish
Copy link
Contributor Author

@DaveTBlake when you have time to review.

@phunkyfish phunkyfish merged commit 6ba3449 into xbmc:master Dec 23, 2020
@phunkyfish phunkyfish deleted the pvr-json-timers-fix branch December 23, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

@DaveTBlake DaveTBlake DaveTBlake approved these changes

Assignees
No one assigned
Labels
API change: JSON-RPC Component: JSON-RPC Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-RC1
Development

Successfully merging this pull request may close these issues.

Missing return parameter 'broadcastid' in JSON-RPC call 'PVR.GetTimers'
3 participants
@phunkyfish @ksooo @DaveTBlake