Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix PVR manager start/stop races #18964

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Dec 21, 2020

Stopping PVR Manager must follow the strict two-step logic for all (!) of its sub components.

  1. Stop all sub components (means, stop their worker threads to hold processing)
  2. Unload all sub components (clearing all data)

Starting must follow the exact revere logic

  1. Load all sub components (loading their data from clients and/or database)
  2. Start all sub components

This was not implemented properly for CPVRTimers and CPVREpgContainer components and should be fixed by this PR.

Runtime-tested on macOS and Android, latest kodi master. I had a testcase reproducible on my Mac which led to all kind of errors and even crashes.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v19 Matrix labels Dec 21, 2020
@ksooo ksooo added this to the Matrix 19.0-RC1 milestone Dec 21, 2020
@ksooo ksooo changed the title [PVr] Fix PVR manager start/stop races [PVR] Fix PVR manager start/stop races Dec 21, 2020
Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ksooo ksooo merged commit 53f8b16 into xbmc:master Dec 22, 2020
@ksooo ksooo deleted the pvr-fix-startstop-races branch December 22, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants