Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pvr] fix epg retrieval which should be by database ID #18947

Merged
merged 1 commit into from
Dec 19, 2020
Merged

[pvr] fix epg retrieval which should be by database ID #18947

merged 1 commit into from
Dec 19, 2020

Conversation

phunkyfish
Copy link
Contributor

@phunkyfish phunkyfish commented Dec 17, 2020 •
edited
Loading

Description

Fix for #18944. The JSON API has also been bumped as a fix is required.

Motivation and Context

How Has This Been Tested?

On OSX

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish added this to the Matrix 19.0-RC1 milestone Dec 17, 2020
@phunkyfish
Copy link
Contributor Author

Jenkins build this please

ksooo
ksooo approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

DaveTBlake
DaveTBlake approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@DaveTBlake DaveTBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to catch this while still in beta

@ksooo
Copy link
Member

ksooo commented Dec 18, 2020

jenkins build this please

@fuzzard
Copy link
Contributor

fuzzard commented Dec 19, 2020

Jenkins build this please

@ksooo
Copy link
Member

ksooo commented Dec 19, 2020

jenkins build this please

@phunkyfish
Copy link
Contributor Author

Jenkins build this please

@ksooo
Copy link
Member

ksooo commented Dec 19, 2020

Jenkins state is actually "Finished: SUCCESS". No idea why github does not pick it up.

@ksooo ksooo merged commit c9da8b4 into xbmc:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

@DaveTBlake DaveTBlake DaveTBlake approved these changes

Assignees
No one assigned
Labels
API change: JSON-RPC Component: JSON-RPC Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phunkyfish @ksooo @fuzzard @DaveTBlake