DVDFileInfo: Consult av_image_get_buffer_size before allocating #18945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malaterre This should be the proper way of doing it. |
|
Jenkins build this please |
lrusak
reviewed
Dec 20, 2020
lrusak
approved these changes
Dec 21, 2020
As we have intrinsics in use and sws_scale needs proper alignment and proper dimensions, we not only shall continue to use av_malloc but also make sure that size / Height % 16 == 0.
|
Thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have intrinsics in use and sws_scale needs proper alignment and
proper dimensions, we not only shall continue to use av_malloc but
also properly align the buffer size to not write out of the picture.
Fixes: #18935