[Subtitles][Ass] Fix non-working ASS-Override setting #18794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
reviewed
Nov 15, 2020
lrusak
reviewed
Nov 15, 2020
lrusak
reviewed
Nov 15, 2020
|
Comments addressed @lrusak, thanks |
lrusak
reviewed
Nov 15, 2020
| { | ||
| XFILE::CFile::Copy(fontPath, finalFontPath); | ||
| CLog::Log(LOGDEBUG, "CDVDSubtitlesLibass: Copied {} to {}", fontPath, finalFontPath); | ||
| return; |
There was a problem hiding this comment.
Should you return earlier here? Will the the second path exist if the first path does?
There was a problem hiding this comment.
Second folder (system one) is only used if the font being added can not be found in the media/fonts folder. It was implemented like this before as well.
As far as I can see, kodi will include arial and teletext by default in the system folder. You should be able to select those fonts and use the setting even if you have not added any fonts to your media folder.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This setting "Override ASS/SSA subtitle fonts" is broken in Kodi 19 (doesn't do anything). The problem is that libass is configured with
special:https://temp/fontsas the font folder (to where the demuxer extracts the subtitle files) but when a font is selected in Kodi it is usually inspecial:https://home/media/Fonts/. Since you can't append multiple folders to libass, If the user wants to use a system configured font, it has to be also copied to the temp folder before the lib is configured.Motivation and Context
Fixes an issue reported in IRC
How Has This Been Tested?
With mkv's containing muxed ass subtitles. Also tested all the samples in the team ftp server.
Screenshots (if appropriate):
Configured settings:
Previous behaviour:
PR:
Types of change