[EDL] Remove const in MillisecondsToTimeString

xbmc · Jun 22, 2024 · 38baff7 · 38baff7
1 parent b446e55
commit 38baff7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/xbmc/cores/VideoPlayer/Edl.cpp b/xbmc/cores/VideoPlayer/Edl.cpp
@@ -928,10 +928,11 @@ bool CEdl::GetNextSceneMarker(bool bPlus, const int iClock, int *iSceneMarker)
  return bFound;
 }
 
-std::string CEdl::MillisecondsToTimeString(const int iMilliseconds)
+std::string CEdl::MillisecondsToTimeString(int milliSeconds)
 {
- std::string strTimeString = StringUtils::SecondsToTimeString((long)(iMilliseconds / 1000), TIME_FORMAT_HH_MM_SS); // milliseconds to seconds
- strTimeString += StringUtils::Format(".{:03}", iMilliseconds % 1000);
+ std::string strTimeString = StringUtils::SecondsToTimeString(
+ static_cast<long>(milliSeconds / 1000), TIME_FORMAT_HH_MM_SS); // milliseconds to seconds
+ strTimeString += StringUtils::Format(".{:03}", milliSeconds % 1000);
  return strTimeString;
 }
 

diff --git a/xbmc/cores/VideoPlayer/Edl.h b/xbmc/cores/VideoPlayer/Edl.h
@@ -146,10 +146,7 @@ class CEdl
  // to not modify the parameter on stack
  bool GetNextSceneMarker(bool bPlus, const int iClock, int *iSceneMarker);
 
- // FIXME: remove const modifier as it makes no sense as it means nothing
- // for the reader of the interface, but limits the implementation
- // to not modify the parameter on stack
- static std::string MillisecondsToTimeString(const int iMilliseconds);
+ static std::string MillisecondsToTimeString(int milliSeconds);
 
 private:
  // total cut time (edl cuts) in ms