Add env vars for Workspace, Region and Branch #54
Conversation
| // return default value if not found | ||
| func getEnvVar(name string, defaultValue string) string { | ||
| if val, found := os.LookupEnv(name); found { | ||
| return val |
There was a problem hiding this comment.
I noticed that if the .env file doesn't exist we return an empty string instead of the default value, is that correct?
There was a problem hiding this comment.
Yes, that is correct. It's fine for now, as we only fetch an env var to bootstrap the connection params and if an empty string is encountered, continues to probe the .xatarc file.
xata/utils.go
Outdated
| // Get the region if the corresponding env var `XATA_REGION` is set | ||
| // otherwise return the default region: us-east-1 | ||
| func getRegion() string { | ||
| return getEnvVar("XATA_REGION", defaultRegion) |
There was a problem hiding this comment.
nit: We appear to sometimes uses the raw string value of the environment variable names and sometimes constants. I think we should switch to constants everywhere. I'm happy to do this as a separate PR as doing it as part of this one could get messy.
There was a problem hiding this comment.
that's a good nit, I felt guilty not doing it :) I'll push it up in a sec and share the commit.
There was a problem hiding this comment.
We still use the string values in a lot of tests. To get around this we'd have to make the constants public.
The workspace Id can be set via env var
XATA_WORKSPACE_ID. This env var takes precedence over the.xatarcfile. TheXATA_WORKSPACE_IDis present, there is an additional lookup for the env varsXATA_BRANCHandXATA_REGION.