Parameterize schema in which migration tests run via PGROLL_TEST_SCHEMA env var
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to specify `TestCase` here.
exekias
approved these changes
Feb 5, 2024
Default to running tests in the 'public' schema, but allow this to be overridded via the `PGROLL_TEST_SCHEMA` env var.
8f2279f
to
9d38e6f
Compare
This was referenced Feb 6, 2024
andrew-farries
added a commit
that referenced
this pull request
Feb 7, 2024
Remove the schema component from index names in the internal schema representation. A `pgroll` migration is always run in the context of a a specific schema so the extra qualification is redundant. Removing the schema component from the index names makes it easy to identify duplicated indexes by name when temporary columns and associated attributes are renamed on migration completion. Tests for this change are already in place (#276, #277). As of this PR, migration tests run in a non-public schema will pass: ```bash PGROLL_TEST_SCHEMA=foo go test ./... ``` Part of #273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterize the migration tests so that the schema in which migrations are applied is taken from the
PGROLL_TEST_SCHEMAenvironment variable, orpublicif unset.#273 highlights an area in which there is a lack of test coverage: migration tests apply migrations only in the
publicschema. #273 is an error that is only reproducible when running migrations in a non-publicschema and there are currently also other problems with migration validation in non-publicschema.This PR makes repetitive changes to all tests:
afterStart,afterCompleteandafterRollbackhooks to take aschema stringparameter."public"in those hooks with theschemaparameter.Later PRs will fix the issues with running migrations in non-
publicschema and run non-publicmigration tests in CI. For now, to run migration tests in a non-publicschema run:Part of #273