Parameterize schema in which migration tests run via PGROLL_TEST_SCHEMA
env var
#276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterize the migration tests so that the schema in which migrations are applied is taken from the
PGROLL_TEST_SCHEMA
environment variable, orpublic
if unset.#273 highlights an area in which there is a lack of test coverage: migration tests apply migrations only in the
public
schema. #273 is an error that is only reproducible when running migrations in a non-public
schema and there are currently also other problems with migration validation in non-public
schema.This PR makes repetitive changes to all tests:
afterStart
,afterComplete
andafterRollback
hooks to take aschema string
parameter."public"
in those hooks with theschema
parameter.Later PRs will fix the issues with running migrations in non-
public
schema and run non-public
migration tests in CI. For now, to run migration tests in a non-public
schema run:Part of #273