Modify GraphQL query to uniquely identify issues #35
Conversation
| const query = `query($owner:String!, $name:String!, $creator:String!, $label:String!){ | ||
| repository(owner: $owner, name: $name) { | ||
| issues(first: 1, states: OPEN, filterBy: {createdBy: $creator, labels: [$label]}, orderBy: {field: CREATED_AT, direction: DESC}) { | ||
| issues(first: 100, states: OPEN, filterBy: {createdBy: $creator, labels: [$label]}, orderBy: {field: CREATED_AT, direction: DESC}) { |
There was a problem hiding this comment.
100 is the maximum limit for the first: query. This can potentially be reduced. However, I would still suggest keeping it to a reasonable amount, because it already has to be >1 to be able to check for titles across issues.
Since it's already running through GitHub API with ${{ github.token }}, I don't think we'll hit any rate limits.
|
Hi, @keewis – thanks for providing the opportunity to contribute. I think this should be ready for review, so I'm tagging you here :) |
|
thanks for the PR, @agriyakhetarpal. I'm somewhat busy this week so it will take me a while for a full review, but I will try to get to it as soon as possible. |
|
No worries! I will be happy to add additional documentation about this change to the inputs in |
|
@agriyakhetarpal, sorry for the long silence here. I've investigated the proposed fix and decided it would be easier / cleaner to use the GraphQL In any case, your implementation allowed me to skip a lot of investigation (and I'll repurpose this PR to fix the style issues). |
Description
This PR updates the GraphQL search query currently being run against the GitHub API to look not just for issues by a particular creator but also to match the title in the search query.
This allows for the use of GitHub Actions variables and contexts coming from matrices or job IDs or similar in the issue, such as
and therefore allow the creation of and updates to issues based on these custom issue titles, and prevent updating the body of a singular issue if multiple jobs (or matrices) are being used to create issues.
What issue does this PR address?
Closes #34
Additional context
The changes can be verified in workflow runs and through the issues opened by the action on my fork, here: agriyakhetarpal#1, displaying that the proposed changes are working as usual.