This repository has been archived by the owner on May 15, 2024. It is now read-only.
Fix #1999 - checkasync should return restricted for locationinuse whe… #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n only coarse is granted
|
Seems to work! I made a small test project for this here: https://github.com/Cheesebaron/EssentialsLocationPermissionTest |
Cheesebaron
approved these changes
May 6, 2022
|
Thanks so much @Cheesebaron @aritchie <3 |
jfversluis
approved these changes
May 6, 2022
1 task
1 task
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Ensuring Permissions.LocationWhenInUse.CheckAsync on Android returns Restricted if only coarse permission is granted
Bugs Fixed
API Changes
LocationWhenInUse & pulled out CheckSelfPermission out of the loop so it can be used for individual checks
Changed:
Since CheckSelfPermission was moved to DoCheck, BasePlatformPermission.CheckStatusAsync had it's loop code pointed at new method.
LocationWhenInUse overrides CheckAsync now
Behavioral Changes
If AccessFineLocation is denied, but AccessCoarseLocation is granted - PermissionStatus.Restricted is now returned
PR Checklist
mainat time of PR