Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative function names #31

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

ayushpatnaikgit
Copy link
Member

Changing

  1. bias_correction to PSTT_biascorrect as the function is part of the PSTT paper
  2. Similarly, conventional_cleaning to `PSTT_conventional()
  3. And PatnaikSTT2021 to PSTT2021, which is more concise.

Adding a function clean_complete which is best full cleaning method as of today.

@codecov-commenter
Copy link

Codecov Report

Merging #31 (f87a0c3) into main (8ffc24b) will increase coverage by 0.37%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   74.96%   75.33%   +0.37%     
==========================================
  Files          23       23              
  Lines         667      669       +2     
==========================================
+ Hits          500      504       +4     
+ Misses        167      165       -2     
Impacted Files Coverage Δ
src/data_cleaning/full_procedures.jl 95.23% <60.00%> (-4.77%) ⬇️
src/data_cleaning/bias_correction.jl 97.14% <100.00%> (ø)
src/data_cleaning/interpolation.jl 92.30% <0.00%> (+15.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ayushpatnaikgit ayushpatnaikgit merged commit f823f55 into xKDR:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants