Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots #26

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Plots #26

merged 3 commits into from
Aug 15, 2022

Conversation

Tumon2001
Copy link
Contributor

Modified plot_datacube to take filename as an argument

@codetalker7
Copy link
Member

The example code needs to go in a julia codeblock; also, it'll be great if the signature of the functions can be added to the docstrings, along with a one line description of what the function is doing. So, it could look something like:

"""
    plot_datacube(datacube, coordinate_system, date)

One line description of the function and it's arguments.

# Example

```julia
# Example code goes here
```
"""

Also, can types be added to the arguments? That way it'll be clearer from the signature what objects can be passed to the function.

@codetalker7 codetalker7 linked an issue Aug 12, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #26 (96ca291) into main (e48fc82) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   75.56%   75.56%           
=======================================
  Files          23       23           
  Lines         667      667           
=======================================
  Hits          504      504           
  Misses        163      163           
Impacted Files Coverage Δ
src/plot.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ayushpatnaikgit ayushpatnaikgit merged commit 8ffc24b into xKDR:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots
4 participants