-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zip): hooks #993
feat(zip): hooks #993
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
No idea why my branch also updates the gif but I guess it doesn't hurt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks, this looks good!
Checks are failing because you need to add the new hooks to the E2E test: https://github.com/wxt-dev/wxt/blob/main/packages/wxt/e2e/tests/hooks.test.ts |
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-svelte
@wxt-dev/module-solid
@wxt-dev/module-vue
wxt
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 81.96% 81.92% -0.05%
==========================================
Files 127 127
Lines 6622 6628 +6
Branches 1104 1101 -3
==========================================
+ Hits 5428 5430 +2
- Misses 1180 1184 +4
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Aaron <[email protected]>
Opps forgot to run them because I am used to CI letting me know haha |
I made the zip test add firefox as the browser so it also calls the sources hooks |
Closes #962