Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zip): hooks #993

Merged
merged 9 commits into from
Sep 26, 2024
Merged

feat(zip): hooks #993

merged 9 commits into from
Sep 26, 2024

Conversation

Timeraa
Copy link
Contributor

@Timeraa Timeraa commented Sep 25, 2024

Closes #962

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit cbb1dbf
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66f4b36e4d49bf0008484a67
😎 Deploy Preview https://deploy-preview-993--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeraa
Copy link
Contributor Author

Timeraa commented Sep 25, 2024

No idea why my branch also updates the gif but I guess it doesn't hurt

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks, this looks good!

packages/wxt/src/core/zip.ts Outdated Show resolved Hide resolved
packages/wxt/src/types.ts Outdated Show resolved Hide resolved
@aklinker1
Copy link
Collaborator

Checks are failing because you need to add the new hooks to the E2E test: https://github.com/wxt-dev/wxt/blob/main/packages/wxt/e2e/tests/hooks.test.ts

Copy link

pkg-pr-new bot commented Sep 25, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@993

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@993

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@993

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@993

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@993

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@993

wxt

pnpm add https://pkg.pr.new/wxt@993

commit: cbb1dbf

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (efcb593) to head (cbb1dbf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   81.96%   81.92%   -0.05%     
==========================================
  Files         127      127              
  Lines        6622     6628       +6     
  Branches     1104     1101       -3     
==========================================
+ Hits         5428     5430       +2     
- Misses       1180     1184       +4     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Timeraa
Copy link
Contributor Author

Timeraa commented Sep 25, 2024

Checks are failing because you need to add the new hooks to the E2E test: https://github.com/wxt-dev/wxt/blob/main/packages/wxt/e2e/tests/hooks.test.ts

Opps forgot to run them because I am used to CI letting me know haha

@Timeraa
Copy link
Contributor Author

Timeraa commented Sep 25, 2024

I made the zip test add firefox as the browser so it also calls the sources hooks

@aklinker1 aklinker1 merged commit 247cd66 into wxt-dev:main Sep 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zip:* hooks
2 participants