Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove email from changelog #1027

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mezannic
Copy link
Contributor

@mezannic mezannic commented Oct 3, 2024

I misconfigured my privacy settings, so my email address was made visible

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 44f36a0
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66fe8fe0e23a9d00086da7be
😎 Deploy Preview https://deploy-preview-1027--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeraa
Copy link
Contributor

Timeraa commented Oct 3, 2024

Harsh reality it's always gonna be there even if you remove it... Git history

@aklinker1 aklinker1 merged commit ca29419 into wxt-dev:main Oct 3, 2024
4 checks passed
@aklinker1
Copy link
Collaborator

Woops, missed that one. Usually I manually remove email addresses after releases

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (d75f64d) to head (44f36a0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   82.21%   82.02%   -0.19%     
==========================================
  Files         127      127              
  Lines        6633     6633              
  Branches     1104     1106       +2     
==========================================
- Hits         5453     5441      -12     
- Misses       1166     1178      +12     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mezannic
Copy link
Contributor Author

mezannic commented Oct 5, 2024

Harsh reality it's always gonna be there even if you remove it... Git history

Yes, I know, but at least it is less visible ^^'

Woops, missed that one. Usually I manually remove email addresses after releases

No problem, it made me realize there was something wrong with my setup ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants