Extract sbt-airframe as a separate GitHub project #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
=======================================
Coverage 82.77% 82.77%
=======================================
Files 310 310
Lines 12253 12253
Branches 753 753
=======================================
+ Hits 10142 10143 +1
+ Misses 2111 2110 -1
Continue to review full report at Codecov.
|
62 tasks
|
cc: @wvlet/airframe-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts sbt-airframe module as a separate GitHub project https://github.com/wvlet/sbt-airframe.
This is for simplifying the cross build settings.
Currently, sbt-plugin must use only Scala 2.12, while the other airframe modules can be built with Scala 2.13 and Scala 3.
Having a sbt-plugin inside the same project has caused a lot of dependency errors when switching to Scala 2.13 or Scala 3.
With this change, we can make the default Scala version of Airframe at least to Scala 2.13. And also, cross building Scala.js projects with Scala 3 will be possible.