Round to nearest 0.5 db when setting volume #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rxv library interface passes around well understood db volumes over it's interface, values such as -53.5db and the like. The Yamaha API operates in terms of deci-db as an integer - i.e. 535. However, most (if not all) Yamaha receivers have a 5 deci db resolution, and trying to set values such as 531 cause an error. This change makes the rxv library round all set calls up to the nearest half db to remove these errors. These are especially triggered when coming from Home Assistant which has it's own 0 - 100 idea of volume, so is very often not hitting a defined db boundary. Closes Bug wuub#35
:D |
|
Can we get a release cut with this? It would close a Home Assistant bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rxv library interface passes around well understood db volumes
over it's interface, values such as -53.5db and the like. The Yamaha
API operates in terms of deci-db as an integer - i.e. 535.
However, most (if not all) Yamaha receivers have a 5 deci db
resolution, and trying to set values such as 531 cause an error. This
change makes the rxv library round all set calls up to the nearest
half db to remove these errors. These are especially triggered when
coming from Home Assistant which has it's own 0 - 100 idea of volume,
so is very often not hitting a defined db boundary.
Closes Bug #35