Introduce logging for failed requests. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. Can we improve it a little bit before merging? No real changes just nitpicking and readability :)
|
|
All sounds like good feedback, I'll respin the patch with those improvements tonight. |
In response to Home Assistant bug - home-assistant/core#4226 When things go wrong with a request in unexpected ways, we really don't have enough information to figure out what just happened. This is especially true with hardware generations that none of the upstream developers have. This adds logging support to the library, and introduces a couple of error cases where we will log low level details of a failure to help debug these kinds of issues in the future.
play_status can get called on sources that don't support it, which causes a vague XML exception to bubble up through the system. Much better to be cautious and only call it on inputs we know support it.
|
Updated, plus a fix on top for Home Assistant bug - home-assistant/core#4226 |
|
thanks :) |
|
Great, thanks! When you get chance, can we get another release out so we can do a req bump for the Home Assistant bug? |
|
In 8 to 10 hours. |
|
v0.3.1 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to Home Assistant bug -
home-assistant/core#4226
When things go wrong with a request in unexpected ways, we really
don't have enough information to figure out what just happened. This
is especially true with hardware generations that none of the upstream
developers have.
This adds logging support to the library, and introduces a couple of
error cases where we will log low level details of a failure to help
debug these kinds of issues in the future.