Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing volatile keyword in double checked locking #351

Closed
romanstrobl opened this issue Nov 9, 2020 · 0 comments
Closed

Missing volatile keyword in double checked locking #351

romanstrobl opened this issue Nov 9, 2020 · 0 comments
Assignees
@romanstrobl
Labels
bug

Comments

@romanstrobl
Copy link
Member

The volatile keyword should be added into KeyGenerator class for the random field to avoid lock evasion issues when the class is used from multiple threads.
@romanstrobl romanstrobl added the bug label Nov 9, 2020
@romanstrobl romanstrobl self-assigned this Nov 9, 2020
romanstrobl added a commit that referenced this issue Nov 10, 2020
@romanstrobl
Merge pull request #352 from /issues/351-volatile-keyword
9cad838 
Fix #351: Missing volatile keyword in double checked locking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romanstrobl romanstrobl

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romanstrobl