Show device names #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh god openssl and ci is always a pain! one day I'll get it working... |
4eedae5
to
d44b874
Compare
Shouldn't try and recv data when the channel is closed.
ca8dc7c
to
4157b07
Compare
|
I believe that the OBS dependencies include OpenSSL, so being able to use the mechanism that they use for their CI may be sufficient. |
I wasn't able to find this. As far as I'm aware OpenSSL isn't included in the OBS dependencies - they use Mbed TLS instead of OpenSSL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds device names using libimobiledevice.
One major thing is that libimobiledevice requires OpenSSL which in my experience has always been pain to get linked correctly, especially cross platform. I think I might need some help on this. Right now, I've made the required modifications to Portal that will fetch the device names, and I used
brew install opensslto get the OpenSSL binaries on my system to build it locally. I will have to spend some time getting it working on CI, Windows & then make sure that I've not dynamically linked it.Onwards and upwards! This'll be a nice change for everyone.