Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual title for Person blocks embeded via layout does not take. #294

Open
2 tasks done
mariacha opened this issue Jul 25, 2024 · 2 comments
Open
2 tasks done
Assignees

Comments

@mariacha
Copy link
Collaborator

mariacha commented Jul 25, 2024

Describe the bug
When fixing https://github.com/wri/wriflagship/issues/1047 I introduced a bug where the overriding title DOES display on Paragraphs, but that means the label does not display on blocks embeded via layout builder. So the goal here is to revert a9d3e89 and fix the bug with a paragraph preprocessing function instead, which will set the "label" for the field equal to the block's title (based on the current language).

Query to get pages to check:

SELECt * FROM paragraphs_item LEFT JOIN paragraphs_item_field_data USING (id) WHERE paragraphs_item.type='person_listing'

Dev tasks

  • Revert a9d3e89
  • Fix the bug with a paragraph preprocessing function instead, which will set the "label" for the field equal to the block's title (based on the current language).
mariacha pushed a commit that referenced this issue Jul 26, 2024
…the label of the person listing as the block's title.
@mariacha mariacha self-assigned this Jul 26, 2024
@mariacha
Copy link
Collaborator Author

This has been fixed on Flagship. Since Flagship is not multilingual, the only thing to test is that Person Listing paragraphs continue to have the correct, unique titles:
https://develop-wriflagship.pantheonsite.io/testing-experts-intro-paragraphs
https://develop-wriflagship.pantheonsite.io/simple-page-test

@mariacha
Copy link
Collaborator Author

Bug found on https://develop-wriflagship.pantheonsite.io/cities -- experts should say "Featured Cities Experts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant