-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpage caching issue #178
Labels
Comments
mariacha
pushed a commit
that referenced
this issue
Jul 11, 2023
…l from within a field, because the html gets refreshed each page load, while the field is only refreshed when the page has changed.
I'm seeing much better VR tests coming out of this, which is where the issue was coming from, so moving to Ready to Deploy. |
Pulling this over to work on as part of improving VR tests. |
mariacha
pushed a commit
that referenced
this issue
Jul 16, 2024
…olling the header style and caching doesn't cooperate.#178.
This only really affects VR tests, so I'm moving to Ready to Deploy to continue reviewing once this is merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In VR tests, sometimes a subpage shows up with a white menu, and sometimes it shows up correctly with the menu floating over the hero image. This clears up if you clear the cache, so something must be setting the page without the "transparent-header white" classes. I suspect it's caused when the parent page is looked at and cached before the subpage is (maybe).
Quick note: This is fixed on subpages but can still occur on regular pages where a block in the hero sets the html classes. See
ts_wrin_preprocess_block
-- that only gets hit the first time you load the page. Subsequent times, there will be white at the top.The text was updated successfully, but these errors were encountered: