Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Maps API #44

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Remove Google Maps API #44

merged 2 commits into from
Jun 6, 2024

Conversation

gtempus
Copy link
Contributor

@gtempus gtempus commented Jun 6, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Browser loads the google maps API and dependencies. But, they're not needed.

What is the new behavior?

The google maps API is no longer requested by the browser

Does this introduce a breaking change?

  • Yes
  • No

Copy link

github-actions bot commented Jun 6, 2024

📦 New Docker Image has been pushed to Github Container Registry (GHCR)
Image: ghcr.io/wri/ocean-watch/nextjs-app:remove-google-maps-api-850345c

@gtempus gtempus marked this pull request as ready for review June 6, 2024 21:36
Copy link

github-actions bot commented Jun 6, 2024

🚀 Deployment successful!
🌐 Your service in environment remove-google-maps-api is now available at: https://ocean--Publi-ORBNTUlw60fn-321072509.us-east-1.elb.amazonaws.com

@gtempus gtempus merged commit 6651b7e into main Jun 6, 2024
@gtempus gtempus deleted the remove-google-maps-api branch June 6, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants