-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake WRFPLUS #2089
base: release-v4.6.1
Are you sure you want to change the base?
CMake WRFPLUS #2089
Conversation
…applied globablly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve these changes, but I’m confused about why the WRF binaries have .exe
extensions. Typically, .exe
is used for Windows executables, which could cause confusion for users. Additionally, this could create issues when building WRF in a cross-platform Linux/Windows environment. One of the main advantages of using CMake is its support for cross-platform builds, and this naming convention might undermine that benefit.
Given that this repository will soon move to minimal maintenance, it’s even more important to follow common naming conventions for clarity. Ensuring that executable names are intuitive and platform-appropriate will help reduce user confusion and minimize the need for support as resources become more limited. It will also preserve the long-term maintainability of the project, especially when building across multiple platforms.
TYPE: enhancement
KEYWORDS: cmake, wrfplus
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The current CMake build does not build the WRF PLUS core configuration
Solution:
Add the necessary source files to compile WRF PLUS. WRF binary will still be created, but a symlink to
wrfplus.exe
will also be created for backward compatibility